Fix NPE in ordered-set #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
May 10, 2024
| @@ -56,7 +56,7 @@ | |||
| (toString [this] | |||
| (str "#{" (clojure.string/join " " (map str this)) "}")) | |||
| (hashCode [this] | |||
| (reduce + (map #(.hashCode ^Object %) (.seq this)))) | |||
| (reduce + (keep #(when % (.hashCode ^Object %)) (.seq this)))) | |||
There was a problem hiding this comment.
This doesn't look good to me, since false will be treated the same way here as nil
There was a problem hiding this comment.
Good catch. Highly recomended to add an explicit test case with false as an element of a set, to confirm, and then fix the expected issue that such a test case should find.
NoahTheDuke
added a commit
that referenced
this pull request
May 10, 2024
Fast-follow to #74 Fix NPE in ordered sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the existing
flatland.ordered.set-test/nil-hash-code-npetest as it was incorrectly written and never actually checked that ordered sets can contain nulls. Oops!Closes #73