Update Material-components to 0.13.0, change to dosh to fail on failure #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both variants fail. Is there a general problem with CircleCI accessing npm registry right now? It seems like it was working 2 hours before my first PR. |
|
I updated CI setup Node yesterday, it is possible that broke something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
Extern: The API did not change.
I have updated to 0.13.0, as that was released yesterday, and I also changed sh to dosh.
dosh allows circleci to fail if the build doesn't work. It built fine on node 8.1.0 on my local MacMini.
This may solve #1203.