Skip to content

Enhance exception message in update_bulk_unique_0_u32_u64_u64 method #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ch4r1ty
Copy link

@ch4r1ty ch4r1ty commented Mar 12, 2025

  • Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method to provide more detailed information about the discrepancy between expected and actual row counts. This enhancement will aid in debugging and understanding issues related to insufficient rows during bulk updates.

Description of Changes

Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method within the synthetic.cs file. The updated exception message now provides detailed information about the discrepancy between expected and actual row counts. This enhancement will assist in debugging and understanding issues related to insufficient rows during bulk updates.

API and ABI breaking changes

This change does not involve any API or ABI breaking modifications.

Expected complexity level and risk

Complexity Level: 1

This change is a simple string update and does not have complex interactions with existing or future code.

Testing

Completed Tests:

  • Verified that the exception message displays correctly when there are insufficient rows.
    Reviewer Tests:

  • Confirm that the exception message accurately reflects the expected and actual row count differences under various conditions.

- Improved the exception message in the `update_bulk_unique_0_u32_u64_u64` method to provide more detailed information about the discrepancy between expected and actual row counts. This enhancement will aid in debugging and understanding issues related to insufficient rows during bulk updates.
@bfops
Copy link
Collaborator

bfops commented Apr 4, 2025

Hey @ch4r1ty ! Thanks for opening this. Since the benchmarks are currently part of the main SpacetimeDB repo, we ask contributors to sign our Contributor License Agreement (CLA) before we merge their changes.

If you're willing to sign our CLA, could you send an email to [email protected]? After that, this PR LGTM 🙂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants