Remove SSL Enabled parameter to connect and change host to spacetimedb_uri #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
To make the SDKs more consistent, we are moving towards including the protocol in the
spacetimedb_uriparameter to the connect function instead of providing ahostand a bool forsslenabledAPI
If the API is breaking, please state below what will break
The connect function call for existing projects need to be updated to remove the SSLEnabled argument and include the protocol in the
spacetimedb_uriparameterRequires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work