Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the quickstart to use the new 1.0 API #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the quickstart to use the new 1.0 API #130
Changes from all commits
0c36b82
a1b85c1
cee497f
667c0fc
145e818
d6a03d7
f2a8ac8
56120e8
4102fd3
9c099fe
5ba8bf3
40f7cb4
8a1d28b
4d308ca
2a1f7ce
4aa5bcc
1422830
2a84f67
f409b64
40901c1
422f8b0
340ec7f
e06824d
5224d68
b549cce
cff3b22
4c7ad25
fec9d29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the instructions for running this to the readme? As someone who likes to start with being able to run an end-to-end example, then go through the code, it's nice to be able to get clear setup instructions without going through the explanation of how to write the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps are added (Zeke added them)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be more of a comment on the quickstart docs, but I think it would be quicker to get up and running if this linked to the server module code that is ready to be run immediately.