Skip to content

Fix info tests #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix info tests #775

merged 1 commit into from
Jun 26, 2023

Conversation

r0man
Copy link
Contributor

@r0man r0man commented Jun 26, 2023

Orchard changed how arglists-str are formatted for special forms in this PR:

clojure-emacs/orchard#166

It looks like this broke the info tests in cider-nrepl. Assuming the new behaviour is the correct one, I fixed the tests accordingly.

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • [-] You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • [-] You've updated the README (if adding/changing middleware)

Note: If you're just starting out to hack on cider-nrepl you might find
nREPL's documentation and the
"Design" section of the README extremely useful.*

Thanks!

@bbatsov
Copy link
Member

bbatsov commented Jun 26, 2023

Looking at the test failures the type info for the Java methods has not disappeared.

@vemv
Copy link
Member

vemv commented Jun 26, 2023

The failng tests in master 4ff906c seem easy to fix:

 FAIL in (integration-test) (info_test.clj:293)
eldoc op clojure special form
expected: (= (:type response) "function")
  actual: (not (= "special-form" "function"))

lein test :only cider.nrepl.middleware.info-test/integration-test

FAIL in (integration-test) (info_test.clj:299)
eldoc op clojure dot operator
expected: (= (:type response) "function")
  actual: (not (= "special-form" "function")

If there's any other issue, please point to specific CI builds. Local invocations can miss something.

@r0man r0man force-pushed the fix-special-form-tests branch from ba70e39 to 36798ca Compare June 26, 2023 11:39
@vemv vemv merged commit cff4531 into clojure-emacs:master Jun 26, 2023
@vemv
Copy link
Member

vemv commented Jun 26, 2023

Thank you 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants