[inspect] Add support for :table view-mode #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 5, 2025
| @@ -77,7 +77,9 @@ | |||
| (inspector-response msg (swap-inspector! msg #(inspect/refresh % overrides))))) | |||
|
|
|||
| (defn- toggle-view-mode [{:keys [view-mode] :as inspector}] | |||
| (let [toggle-order {:normal :object, :object :normal} | |||
| (let [toggle-order (if (inspect/supports-table-view-mode? inspector) | |||
There was a problem hiding this comment.
I'd add a note here that depends on the underlying data, as I'm not sure it will be obvious from the name of the function alone.
bbatsov
approved these changes
Apr 5, 2025
alexander-yakushev
force-pushed
the
table-view
branch
2 times, most recently
from
b9cc233 to
95f7c90
Compare
alexander-yakushev
force-pushed
the
table-view
branch
from
95f7c90 to
63df941
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR: clojure-emacs/orchard#331
Not a lot to be done here. We already have
inspector-toggle-view-modethat does the heavy lifting. The only meaningful thing here is checking if the current object can be rendered as a table.normal -> table -> object -> normalnormal -> object -> normal.