Skip to content

[stacktrace] Add support for directly inspecting ex-data #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Apr 9, 2025

Changes made to address clojure-emacs/cider#3804.

  1. The op inspect-last-exception now accepts ex-data: true parameter that tells it the user wants to inspect ex-data of the exception directly, not the entire exception. This is used to have separate buttons in *cider-error* buffer for the whole exception and for just ex-data.
  2. Replaced a separate dynamic variable manually stored in the session with storing the last analyzed exception inside session's metadata – the same approach as used by inspector middleware.

  • You've updated the README
  • Middleware documentation is up to date

Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me!

@bbatsov bbatsov merged commit 2f2affe into master Apr 10, 2025
16 checks passed
@alexander-yakushev alexander-yakushev deleted the inspect-ex-data branch April 10, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants