Skip to content

Support M-r like shell mode #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
monsanto opened this issue May 24, 2013 · 7 comments
Closed

Support M-r like shell mode #326

monsanto opened this issue May 24, 2013 · 7 comments

Comments

@monsanto
Copy link

shell-mode (actually comint) has a neat clone of bash's history search. nrepl.el should snap this up.

Unfortunately none of that code is reusable, so this will likely be a copy-paste affair.

@ska2342
Copy link
Contributor

ska2342 commented May 24, 2013

Can you quickly describe the differences between that history search and the one already available in nrepl.el?

Thanks,
Stefan

@monsanto
Copy link
Author

If by the current search functionality you mean nrepl-previous-matching-input, the difference is that nrepl's search functionality is not incremental and shell-mode's is. It's the same difference between search-forward and isearch-forward

If you want to try it out, M-x shell, execute a few commands, and try M-r.

@ska2342
Copy link
Contributor

ska2342 commented May 24, 2013

Understood. nrepl.el mimics the search facility found in SLIME. I do remember having to get used to that compared to the incremental C-r in bash; today it's in my finger memory so I don't care anymore. I wouldn't object to the incremental approach, though.

@Josh-Tilles
Copy link
Contributor

What do you think about going all the way and defining nrepl-mode to be derived from comint-mode?

@bbatsov
Copy link
Member

bbatsov commented Oct 30, 2013

@MerelyAPseudonym Yep, that would be ideal. Hopefully I'll do that at some point.

@bbatsov
Copy link
Member

bbatsov commented Aug 12, 2014

Closing this in favour of #709.

@bbatsov bbatsov closed this as completed Aug 12, 2014
@vspinu
Copy link
Contributor

vspinu commented Aug 12, 2014

I have started looking into moving cider repl on comint. Plan to get
something running by the end of the week.

On 12 August 2014 08:39, Bozhidar Batsov [email protected] wrote:

Closed #326 #326.


Reply to this email directly or view it on GitHub
#326 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants