Skip to content

Use sync requests in inspector-* #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Use sync requests in inspector-* #1821

merged 1 commit into from
Aug 16, 2016

Conversation

ckoparkar
Copy link

@ckoparkar ckoparkar commented Aug 10, 2016

As discussed in #1807 (comment), the inspector-* fn's use callbacks to interact with the middleware. This PR changes those fn's to use the cider-sync-request:*.

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)
  • You've updated the refcard (if you made changes to the commands listed there)

Thanks!


;; Render Inspector from Structured Values
(defun cider-inspector--value-handler (value)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should change this name. But I couldn't think of anything better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about cider-inspector--render-value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I hadn't used that one because we already have a couple of render methods here :-) But that does seem to be the best one. Changed it now.

@bbatsov bbatsov merged commit bdccd2e into clojure-emacs:master Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants