Fix #3307: Incorrect special-form eldocs #3323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is the CIDER companion to [this PR](clojure-emacs/orchard#166) in orchard, which lets us know if the symbol we're querying eldocs for is a special form or an ordinary function. This changes uses that information to deduplicate the arglists for the special form. In the process, the change adds a `cider-eldoc-format-special-form` function, which serves as a home for special form formatting. This change also adds a unit test for cider-eldoc to ensure that it calls the appropriate formatting methods.
vemv
reviewed
Feb 23, 2023
|
You'll also have to rebase on top of |
|
@quanticle ping :-) |
|
@quanticle Ping 2 :-) |
|
@vemv As you had some small suggestion do you want to drive this PR to the finish line? Alternatively I can just merge it as is. |
|
Yep - saving it for the weekend then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3307: Incorrect special-form eldocs
This fix is the CIDER companion to this PR in orchard, which lets us know if the symbol we're querying eldocs for is a special form or an ordinary function.
This change uses that information to deduplicate the arglists for the special form. In the process, the change adds a
cider-eldoc-format-special-formfunction, which serves as a home for special form formatting.Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.