Skip to content

[completion] Don't pass :same if context string hasn't changed #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Jan 29, 2024

Fixes #3613

This has been a quite awkward premature optimization that turned up to be unnecessary. The support for it has been broken in Compliment 0.5.1.

@alexander-yakushev alexander-yakushev force-pushed the compliment-no-same-context branch from 19bbb18 to 8d1dfd4 Compare January 29, 2024 12:49
@alexander-yakushev
Copy link
Member Author

Addresses #3613.

@alexander-yakushev alexander-yakushev force-pushed the compliment-no-same-context branch from 8d1dfd4 to 142e721 Compare January 29, 2024 12:55
Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This has been a quite awkward premature optimization that turned up to be
unnecessary. The support for it has been broken in Compliment 0.5.1.
@alexander-yakushev alexander-yakushev force-pushed the compliment-no-same-context branch from 142e721 to 1863380 Compare January 29, 2024 13:13
@vemv vemv merged commit 7a83b08 into master Jan 29, 2024
@vemv vemv deleted the compliment-no-same-context branch January 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto completion is not reliable after switching to cider-nrepl 0.45.0
2 participants