Skip to content

cider-ns-refresh: summarize errors as an overlay #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

cider-ns-refresh: summarize errors as an overlay #3629

merged 1 commit into from
Mar 7, 2024

Conversation

vemv
Copy link
Member

@vemv vemv commented Mar 7, 2024

Fixes #3628

Sample after a refresh:

image

For the moment I think it will be best not to offer defcustoms for hiding the overlay or the stacktrace. At some point we could hide the stacktrace depending on the nature of the exception, but that needs some work.

Cheers - V

@vemv vemv requested a review from bbatsov March 7, 2024 10:12
@bbatsov bbatsov merged commit 9edb2d2 into master Mar 7, 2024
@bbatsov
Copy link
Member

bbatsov commented Mar 7, 2024

Looks good to me!

@bbatsov bbatsov deleted the 3628 branch March 7, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cider-ns-refresh: summarize errors as an overlay
2 participants