[completion] Enable cider-completion-style by default #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
default-completion-style
branch
from
cfe9735 to
bcaceda
Compare
bbatsov
reviewed
Mar 27, 2025
cider-completion.el
Outdated
|
|
||
| ;; Enable cider-completion-style by default. Users can opt out of this by | ||
| ;; running (cider-enable-cider-completion-style -1) | ||
| (cider-enable-cider-completion-style 1) |
There was a problem hiding this comment.
I think we should do this in the minor-mode, as it's not very nice to run code at the top-level in general.
bbatsov
reviewed
Mar 27, 2025
|
|
||
| This style supports non-prefix completion candidates returned by the | ||
| completion backend. Only affects the `cider' completion category." | ||
| completion backend. Only affects the `cider' completion category. If ARG | ||
| is `1' or nil, enables the custom completion style; if `-1', disables it." |
There was a problem hiding this comment.
Might be more idiomatic for anything non-nil to enable it and for nil to disable it.
There was a problem hiding this comment.
The problem is that people currently have this function in their configs, and it now accepts zero arguments. To reuse the same function, we need to make ARG optional, and it means it arrives as nil when people want to enable.
There was a problem hiding this comment.
@bbatsov So is this OK to leave as is or is there a better solution?
|
No objections from me! |
alexander-yakushev
force-pushed
the
default-completion-style
branch
from
bcaceda to
47c7487
Compare
bbatsov
reviewed
Mar 28, 2025
alexander-yakushev
force-pushed
the
default-completion-style
branch
from
47c7487 to
9768973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm feeling lucky about enabling our custom
cider-completion-styleby default. We had some troubles with it in the past – it worked not according to how completion spec expected it, but now these issues are fixed as far as I can tell. The other reason why it took long to fix it is that this was optional and I don't think many users enabled it, so we didn't receive enough data about the bug we had.Anyway, I've been using this since forever and I'm confident now that this is a net positive feature to have on for everybody. I've modified
cider-enable-cider-completion-styleto acceptARG = -1to have a way for users to disable this if they don't want it (in the same way as they now enable it).