Skip to content

add option to control whether loading a buffer prompts you to save the corresponding file #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2014

Conversation

cemerick
Copy link
Contributor

@cemerick cemerick commented Feb 5, 2014

fixes gh-469

@@ -87,6 +87,10 @@ which will use the default REPL connection."
:type 'symbol
:group 'cider)

(defcustom cider-prompt-save-file-on-load t
"When t, cider will prompt you to save the corresponding file when loading a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Elisp the first line of the docstring should be a complete sentence (or M-x checkdoc will complain).

@bbatsov
Copy link
Member

bbatsov commented Feb 5, 2014

You should also mention this in the README and the CHANGELOG.

@cemerick
Copy link
Contributor Author

cemerick commented Feb 5, 2014

Interesting re: the docstring thing. Thanks.

Updated with a fix for that, and CHANGELOG note. I'm not sure what to add to the README, since this is a fix; it doesn't change any user expectations AFAICT.

@cemerick
Copy link
Contributor Author

cemerick commented Feb 5, 2014

Shite, mixed up my issues, sorry…

* [#460](https://github.com/clojure-emacs/cider/issues/316) Support for cider-nrepl's complete middleware for CLJ/CLJS autocomplete.
* [#460](https://github.com/clojure-emacs/cider/issues/316) Support for
cider-nrepl's complete middleware for CLJ/CLJS autocomplete.
* [#470](https://github.com/clojure-emacs/cider/issues/470) Ensure that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you wrote a changelog entry for another issue :-)

@bbatsov
Copy link
Member

bbatsov commented Feb 5, 2014

No problem. As for the README - there's a section on customization there. You can just write two lines there. "If you want to change ..., set ...".

@cemerick
Copy link
Contributor Author

cemerick commented Feb 5, 2014

OK, maybe it's done now. :-P Yeah, I was thinking about the pprint/*1 issue when I said that about the README.

bbatsov added a commit that referenced this pull request Feb 5, 2014
add option to control whether loading a buffer prompts you to save the corresponding file
@bbatsov bbatsov merged commit 53458df into clojure-emacs:master Feb 5, 2014
@bbatsov
Copy link
Member

bbatsov commented Feb 5, 2014

👍 Yep, you're done. :-)

@danielcompton
Copy link
Contributor

danielcompton commented Jul 8, 2019

For future searchers, this has been renamed to cider-save-file-on-load from cider-prompt-save-file-on-load in CIDER 0.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cider-load-current-buffer always prompts to save the file if modified
3 participants