Skip to content

Don't drop *out* on cider-interactive-eval-print #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2014

Conversation

gfredericks
Copy link
Contributor

Print *out* to the repl buffer just like in cider-interactive-eval.

I think this is a more common expectation than dropping the *out*. Is there a better way to do this, perhaps so that it's configurable? I pretty much haven't written any elisp ever.

Print *out* to the repl buffer just like in cider-interactive-eval.
@bbatsov
Copy link
Member

bbatsov commented May 18, 2014

I'll have to think about this. Clear the current situation is suboptiomal as we should preserve the output somewhere, but on the other hand it seems odd to send to the REPL output from code that wasn't executed there. I was thinking at some point that maybe we need some extra buffer like cider-output for output generated from interactive evaluations.

@gfredericks
Copy link
Contributor Author

C-x C-e already does this, right? You evaluate code in the code buffer, the result goes to the minibuffer, but *out* goes to the repl buffer.

This patch actually consists of just copying the code from that codepath.

I don't mind the cider-output idea though.

@bbatsov
Copy link
Member

bbatsov commented May 18, 2014

@fredericksgary Yeah, the code you've submitted is OK. I was talking about the more general issue of whether it's a good idea to funnel the output from everything in the REPL buffer. See my last comment in #572.

bbatsov added a commit that referenced this pull request May 23, 2014
Don't drop *out* on cider-interactive-eval-print
@bbatsov bbatsov merged commit 3563498 into clojure-emacs:master May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants