Skip to content

Switch to using CircleCI #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Switch to using CircleCI #159

merged 1 commit into from
Feb 28, 2019

Conversation

danielcompton
Copy link
Contributor

@danielcompton danielcompton commented Feb 27, 2019

Follows the pattern in clojure-emacs/clojure-mode#514. There was a large Travis test matrix, but it doesn't appear as if the MAKE_TEST env var was actually being used in the tests, they all seem to be running cask exec buttercup to do the testing.

You can see the tests running at https://circleci.com/gh/danielcompton/workflows/inf-clojure/tree/use-circle.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@arichiardi
Copy link
Contributor

Looks very good to me, let me try it out

@arichiardi arichiardi merged commit b29a3f1 into clojure-emacs:master Feb 28, 2019
@arichiardi
Copy link
Contributor

Thank you it works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants