Skip to content

Add clojure-ts-mode support #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025

Conversation

rrudakov
Copy link
Contributor

#215 has no activity for more than 2 years, so I decided to create a new one.

Initially I planned to add a new inf-clojure-preferred-major-mode variable, but then I discovered inf-clojure-source-modes and I think it's a good idea to use it for this feature.

clojure-ts-mode is used in the most places if selected as a preferred major mode, except a few places where required functions are missing. I left comments in the code.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@rrudakov rrudakov force-pushed the feature/clojure-ts branch from db9a614 to 3164af1 Compare May 24, 2025 16:48
@rrudakov rrudakov force-pushed the feature/clojure-ts branch from 3164af1 to ae8dcea Compare May 24, 2025 16:59
@bbatsov bbatsov mentioned this pull request May 24, 2025
4 tasks
@rrudakov rrudakov force-pushed the feature/clojure-ts branch 3 times, most recently from 7ee985a to 814bc00 Compare May 24, 2025 18:50
@rrudakov rrudakov force-pushed the feature/clojure-ts branch from 814bc00 to 65ca102 Compare May 24, 2025 18:56
@bbatsov bbatsov merged commit ece16ff into clojure-emacs:master May 24, 2025
@rrudakov rrudakov deleted the feature/clojure-ts branch May 24, 2025 19:22
@bbatsov
Copy link
Member

bbatsov commented May 25, 2025

@rrudakov I've noticed that the CI was not running and I fixed it today. Seems your changes introduced a few warnings https://app.circleci.com/pipelines/github/clojure-emacs/inf-clojure/123/workflows/de4bff6a-64d8-458d-8ba7-e337b2ea9eff/jobs/413

Nothing major, but I wanted to mention it so we won't forget about them.

@rrudakov
Copy link
Contributor Author

@rrudakov I've noticed that the CI was not running and I fixed it today. Seems your changes introduced a few warnings https://app.circleci.com/pipelines/github/clojure-emacs/inf-clojure/123/workflows/de4bff6a-64d8-458d-8ba7-e337b2ea9eff/jobs/413

Nothing major, but I wanted to mention it so we won't forget about them.

Thanks. I'll take a look later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants