layout: Add MMIO memory attribute#293
Merged
retrage merged 2 commits intocloud-hypervisor:mainfrom Nov 7, 2023
Merged
Conversation
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
rbradford
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in issue #289, there was an allocation issue with the MMIO region for AArch64 in the EFI layer. This was initially addressed by PR #290, thanks to @jongwu. However, the solution appeared to be somewhat ad-hoc, raising same concerns with the RL011 UART MMIO region.
This PR adds
MemoryAttribute::Mmioand an MMIO memory descriptor for AArch64 memory layout.