Skip to content

ci: Switch arm64 tests to self-hosted GitHub Actions runner#316

Merged
rbradford merged 4 commits intocloud-hypervisor:mainfrom
retrage:switch-arm64-tests-gha
Feb 27, 2024
Merged

ci: Switch arm64 tests to self-hosted GitHub Actions runner#316
rbradford merged 4 commits intocloud-hypervisor:mainfrom
retrage:switch-arm64-tests-gha

Conversation

@retrage
Copy link
Copy Markdown
Contributor

@retrage retrage commented Feb 23, 2024

It looks like we have a self-hosted arm64/linux GitHub Actions runner (cloud-hypervisor/cloud-hypervisor#6221).

Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage requested a review from rbradford February 23, 2024 11:19
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Signed-off-by: Akira Moroo <retrage01@gmail.com>
Copy link
Copy Markdown
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

- name: Run integration tests
run: scripts/dev_cli.sh tests --integration-coreboot No newline at end of file
- if: ${{ matrix.coreboot-tests }}
name: Run coreboot integration tests
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - I saw this the other day when I was reviewing the output.

matrix:
include:
- runner: ubuntu-22.04
coreboot-tests: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind doing something like variant: coreboot here and something like variant: no coreboot - will produce nicer actions titles - otherwise - nice use of matrix!

@rbradford rbradford merged commit 25ac707 into cloud-hypervisor:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants