Skip to content

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 18, 2022

  • Server accepts both: binary and structured encoded events.
  • Emitter contains comment describing how to switch between binary and
    structured encoding for emitted events.

Closes #465

* Server accepts both: binary and structured encoded events.
* Emitter contains comment describing how to switch between binary and
  structured encoding for emitted events.

Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
Copy link
Contributor Author

/cc @pierDipi @sjaakd

Co-authored-by: Pierangelo Di Pilato <[email protected]>
@matejvasek
Copy link
Contributor Author

@pierDipi DCO is now failing

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierDipi pierDipi merged commit 9125136 into cloudevents:master Jul 19, 2022
@pierDipi
Copy link
Member

Thanks @matejvasek!

@matejvasek
Copy link
Contributor Author

@sjaakd does this work for you?

@sjaakd
Copy link

sjaakd commented Jul 19, 2022

Yes. That's perfect. Do you still want me to make a PR on documentation? I guess the code in itself is clear enough now.

Thanks.

@matejvasek
Copy link
Contributor Author

Yes. That's perfect. Do you still want me to make a PR on documentation? I guess the code in itself is clear enough now.

Thanks.

@sjaakd no need if code is clear enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension of Quarkus example with structured content mode

3 participants