Repo specifies min go version of 1.16 to build the project, but build failed with 1.18

[mitch292]

Would be great to confirm the minimum version of go to build. I attempted to build with 1.18 and saw an error in a vendor package

Error: vendor/github.com/prometheus/common/model/metric.go:363:33: undefined: strings.CutPrefix
note: module requires Go 1.20

After confirming minimum version we should update the repo to reflect that. In both the go.mod and the README

[mitch292]

Observe the same thing building locally as on one of the go docker images. 1.19 fails, but build will succeed on 1.20. Building the mutltirootca binary will fail on a prometheus dependency.
1.19

cf-repos/cfssl [mitch292/go-version] » docker build .
[+] Building 49.9s (9/9) FINISHED                                                                                                                                                                docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                                                                             0.0s
 => => transferring dockerfile: 624B                                                                                                                                                                             0.0s
 => WARN: RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is redundant as this is the default behavior (line 1)                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.19                                                                                                                                                   0.5s
 => [internal] load .dockerignore                                                                                                                                                                                0.0s
 => => transferring context: 69B                                                                                                                                                                                 0.0s
 => [1/5] FROM docker.io/library/golang:1.19@sha256:3025bf670b8363ec9f1b4c4f27348e6d9b7fec607c47e401e40df816853e743a                                                                                            12.7s
 => => resolve docker.io/library/golang:1.19@sha256:3025bf670b8363ec9f1b4c4f27348e6d9b7fec607c47e401e40df816853e743a                                                                                             0.0s
 => => sha256:12916f73f9de8e251c4eb4f2d079fa6cd63205b7ba8a7bd88e1f9446105e9ef1 63.99MB / 63.99MB                                                                                                                 4.6s
 => => sha256:b43f8231bf8e9cfe1e388ff2ed95e11e1f63a2275eb44fa7a37d95169aa36c78 1.58kB / 1.58kB                                                                                                                   0.0s
 => => sha256:df70a71c3fbe29bde497ca937b8e0cb93d83e359f641209a7848e1d8cfffd8a0 6.88kB / 6.88kB                                                                                                                   0.0s
 => => sha256:fa34261389f3dee2ecffe9bfe38ae7fd05a1908e98a7486354905aee0f648a6e 49.59MB / 49.59MB                                                                                                                 1.4s
 => => sha256:993525952a483617183655b735562fd3eee4b3a85a472e3dc3c79a258adca100 23.57MB / 23.57MB                                                                                                                 1.6s
 => => sha256:3025bf670b8363ec9f1b4c4f27348e6d9b7fec607c47e401e40df816853e743a 2.36kB / 2.36kB                                                                                                                   0.0s
 => => extracting sha256:fa34261389f3dee2ecffe9bfe38ae7fd05a1908e98a7486354905aee0f648a6e                                                                                                                        1.8s
 => => sha256:0b84cd7f173d9c2c1287768f308d87cd738f9b833164dafc86f19453b6204a6e 86.30MB / 86.30MB                                                                                                                 4.1s
 => => sha256:d20a116de072ace539a45fe44925ff9e0a1127b68fd9bd6a6583830b057be185 115.33MB / 115.33MB                                                                                                               6.9s
 => => extracting sha256:993525952a483617183655b735562fd3eee4b3a85a472e3dc3c79a258adca100                                                                                                                        0.5s
 => => sha256:3b30480db207227e6571e4e4312eddbe2990ce9169981907b30b27eff1dc79f5 154B / 154B                                                                                                                       4.1s
 => => extracting sha256:12916f73f9de8e251c4eb4f2d079fa6cd63205b7ba8a7bd88e1f9446105e9ef1                                                                                                                        2.0s
 => => extracting sha256:0b84cd7f173d9c2c1287768f308d87cd738f9b833164dafc86f19453b6204a6e                                                                                                                        1.7s
 => => extracting sha256:d20a116de072ace539a45fe44925ff9e0a1127b68fd9bd6a6583830b057be185                                                                                                                        3.9s
 => => extracting sha256:3b30480db207227e6571e4e4312eddbe2990ce9169981907b30b27eff1dc79f5                                                                                                                        0.0s
 => [internal] load build context                                                                                                                                                                                0.1s
 => => transferring context: 237.28kB                                                                                                                                                                            0.1s
 => [2/5] RUN echo "I am running on linux/arm64, building for linux/arm64"                                                                                                                                       0.2s
 => [3/5] WORKDIR /workdir                                                                                                                                                                                       0.0s
 => [4/5] COPY . /workdir                                                                                                                                                                                        0.2s
 => ERROR [5/5] RUN git clone https://github.com/cloudflare/cfssl_trust.git /etc/cfssl &&     make clean &&     GOOS=linux GOARCH=arm64 make all && cp bin/* /usr/bin/                                          36.2s
------
 > [5/5] RUN git clone https://github.com/cloudflare/cfssl_trust.git /etc/cfssl &&     make clean &&     GOOS=linux GOARCH=arm64 make all && cp bin/* /usr/bin/:
0.084 Cloning into '/etc/cfssl'...
7.386 rm -rf bin *.deb *.rpm
7.762 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssl ./cmd/cfssl
33.75 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssl-bundle ./cmd/cfssl-bundle
34.03 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssl-certinfo ./cmd/cfssl-certinfo
34.43 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssl-newkey ./cmd/cfssl-newkey
34.73 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssl-scan ./cmd/cfssl-scan
35.00 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/cfssljson ./cmd/cfssljson
35.26 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/mkbundle ./cmd/mkbundle
35.42 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/cloudflare/cfssl/cli/version.version=1.6.5" -o bin/multirootca ./cmd/multirootca
35.70 # github.com/prometheus/common/model
35.70 vendor/github.com/prometheus/common/model/metric.go:363:33: undefined: strings.CutPrefix
35.70 note: module requires Go 1.20
36.10 make: *** [Makefile:12: bin/multirootca] Error 1
------

 3 warnings found (use docker --debug to expand):
 - RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is redundant as this is the default behavior (line 1)
 - LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 7)
 - LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 8)
Dockerfile:16
--------------------
  15 |
  16 | >>> RUN git clone https://github.com/cloudflare/cfssl_trust.git /etc/cfssl && \
  17 | >>>     make clean && \
  18 | >>>     GOOS=${TARGETOS} GOARCH=${TARGETARCH} make all && cp bin/* /usr/bin/
  19 |
--------------------
ERROR: failed to solve: process "/bin/sh -c git clone https://github.com/cloudflare/cfssl_trust.git /etc/cfssl &&     make clean &&     GOOS=${TARGETOS} GOARCH=${TARGETARCH} make all && cp bin/* /usr/bin/" did not complete successfully: exit code: 2

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/m76bd40ob4actxwsag4w0q1mo

Then successful on 1.20

cf-repos/cfssl [mitch292/go-version] » docker build .
[+] Building 57.4s (10/10) FINISHED                                                                                                                                                              docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                                                                             0.0s
 => => transferring dockerfile: 624B                                                                                                                                                                             0.0s
 => WARN: RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is redundant as this is the default behavior (line 1)                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.20                                                                                                                                                  18.4s
 => [internal] load .dockerignore                                                                                                                                                                                0.0s
 => => transferring context: 69B                                                                                                                                                                                 0.0s
 => [1/5] FROM docker.io/library/golang:1.20@sha256:8f9af7094d0cb27cc783c697ac5ba25efdc4da35f8526db21f7aebb0b0b4f18a                                                                                             0.0s
 => [internal] load build context                                                                                                                                                                                0.1s
 => => transferring context: 236.69kB                                                                                                                                                                            0.1s
 => CACHED [2/5] RUN echo "I am running on linux/arm64, building for linux/arm64"                                                                                                                                0.0s
 => CACHED [3/5] WORKDIR /workdir                                                                                                                                                                                0.0s
 => CACHED [4/5] COPY . /workdir                                                                                                                                                                                 0.0s
 => [5/5] RUN git clone https://github.com/cloudflare/cfssl_trust.git /etc/cfssl &&     make clean &&     GOOS=linux GOARCH=arm64 make all && cp bin/* /usr/bin/                                                38.0s
 => exporting to image                                                                                                                                                                                           0.9s
 => => exporting layers                                                                                                                                                                                          0.9s
 => => writing image sha256:69950a908645931cfa6f8c22e4c36a0a3e1bffc62a52ecb83d06e8843d324dde                                                                                                                     0.0s

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/osevvyphcot78ue7j3jjp2iwi

 3 warnings found (use docker --debug to expand):
 - RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is redundant as this is the default behavior (line 1)
 - LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 7)
 - LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 8)

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview

[mitch292]

Looks like bumping prometheus/common from v.0.44.0 to v0.45.0 was the culprit.

v0.44.0 requires go1.18, but v0.45.0 requires go1.20.

Repo has been in this state since 2023-11-05 and not just a library, so I think updating the repo to reflect the go 1.20 requirement rather than reverting back to supporting go 1.16 is the best path forward.