kem: add P-256 + Kyber768Draft00 hybrid #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
bwesterb
force-pushed
the
bas/ckem
branch
2 times, most recently
from
842d8f8 to
9cc25ea
Compare
armfazh
approved these changes
Feb 13, 2023
Contributor
armfazh
left a comment
armfazh
left a comment
There was a problem hiding this comment.
looks good, check my comments.
Also I was wondering if we can reuse the group interface.
Comment on lines
+126
to
+129
| buf := make([]byte, sch.PrivateKeySize()) | ||
| _, _ = h.Read(buf) | ||
| rnd := bytes.NewReader(buf) | ||
| key, x, y, err := elliptic.GenerateKey(sch.curve, rnd) |
Contributor
There was a problem hiding this comment.
Note that GenerateKey function can loop more than once, requesting more bytes from the reader.
Suggested change
| buf := make([]byte, sch.PrivateKeySize()) | |
| _, _ = h.Read(buf) | |
| rnd := bytes.NewReader(buf) | |
| key, x, y, err := elliptic.GenerateKey(sch.curve, rnd) | |
| key, x, y, err := elliptic.GenerateKey(sch.curve, h) |
Member
Author
There was a problem hiding this comment.
Ah, good point. h doesn't implement io.Reader though.
Member
Author
There was a problem hiding this comment.
Ah, I can just use the xof package, nice.
Contributor
There was a problem hiding this comment.
this doesn't address my comment.
you need to pass the xof object, and remove buf.
- xof already implements io.reader
- the issue is that
bufhas fixed size, but it is not guaranteed that reader will be called only one time. It could be called many times.
Member
Author
There was a problem hiding this comment.
You're not looking at the latest diff: there I fixed it. :)
Member
Author
Might be possible, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.