cloudflare-tunnel: configure tunnel protocol#108
Open
miguelvr wants to merge 1 commit intocloudflare:mainfrom
Open
cloudflare-tunnel: configure tunnel protocol#108miguelvr wants to merge 1 commit intocloudflare:mainfrom
miguelvr wants to merge 1 commit intocloudflare:mainfrom
Conversation
nacef3005
approved these changes
Oct 21, 2025
nikskiz
reviewed
Oct 23, 2025
Comment on lines
+44
to
+45
| - '--protocol' | ||
| - {{ .Values.cloudflare.protocol }} |
There was a problem hiding this comment.
Would it be better that this is moved in the config.yaml which is sourced via the configmap?
There was a problem hiding this comment.
Would require implementing it in config.yaml. Current options are a flag or TUNNEL_TRANSPORT_PROTOCOL environment variable.
Author
There was a problem hiding this comment.
flags are better than configs for this type of configuration, because if you change that flag it triggers a deployment restart. If you change the config, it does not affect the deployment unless you have some external mechanism reloading the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows configuring the tunnel protocol via helm values