-
Notifications
You must be signed in to change notification settings - Fork 325
feat(css): support Next Tailwind config and dev layout CSS #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NathanDrake2406
wants to merge
18
commits into
cloudflare:main
Choose a base branch
from
NathanDrake2406:nathan/tailwind-config-smoothness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6b82779
fix(config): support Next Tailwind CSS config shapes
NathanDrake2406 f2ae6f5
chore: rerun ci
NathanDrake2406 239ce00
fix(css): harden dev CSS discovery
NathanDrake2406 2f7b374
fix(config): preserve opaque PostCSS configs
NathanDrake2406 54fc7e9
refactor(css): introduce route asset manifest
NathanDrake2406 8a205b4
fix(css): preserve layout-first asset order
NathanDrake2406 f3091c9
Merge upstream/main into tailwind config smoothness
NathanDrake2406 eb6491e
fix(css): address route asset review notes
NathanDrake2406 ba2da36
chore: rerun ci
NathanDrake2406 3138552
fix(css): avoid crawling package source graphs
NathanDrake2406 a259045
fix(css): address route asset review feedback
NathanDrake2406 20972aa
fix(css): guard dev css ast parsing
NathanDrake2406 4224cdd
refactor(css): address config review nits
NathanDrake2406 836633f
test(config): update turbopack warning assertion
NathanDrake2406 f8261c9
test(css): avoid brittle review assertions
NathanDrake2406 24974c6
chore: merge main into nathan/tailwind-config-smoothness
NathanDrake2406 070e05b
chore: merge main into nathan/tailwind-config-smoothness
NathanDrake2406 67c1b9a
Merge remote-tracking branch 'upstream/main' into nathan/tailwind-con…
NathanDrake2406 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning fires when any rule doesn't match the supported Tailwind-only shape, regardless of whether a Tailwind rule is also present. This is the correct behavior for mixed configs — the Codex review suggestion that this suppresses the warning when any Tailwind loader is detected is incorrect.
One readability nit: the message says "is not generally supported and will be ignored", which is accurate for the non-Tailwind rules but could be read as applying to all rules including the Tailwind one. Consider:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by tightening the warning wording so it applies to unsupported rules specifically while preserving the Tailwind translation note.