add types for event-subscriptions #3814
Open
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
this looks pretty solid to me! |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
penalosa
reviewed
Mar 31, 2025
| Service extends string, | ||
| Type extends string, | ||
| Source, | ||
| Payload = {}, |
There was a problem hiding this comment.
I think this should probably default to Record<string, never> instead? (assuming this is meant to be an empty object)
Comment on lines
+37
to
+42
| type SubscriptionEventSourceWorkflows = { | ||
| workflowId: string; | ||
| workflowName: string; | ||
| versionId: string; | ||
| instanceId: string; | ||
| }; |
There was a problem hiding this comment.
It's a bit weird that workflows has a helper for this, but superSlurper doesn't. Since this type will be exposed to users, I wonder if we should inline it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event Subscriptions let you receive events about other CF products as messages on to a Queue. I'm unsure what other context you all need to be able to review this, but I'm happy to provide it.
WIP Docs change: cloudflare/cloudflare-docs#21197