-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add unsafe.containers #11233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unsafe.containers #11233
Conversation
🦋 Changeset detectedLatest commit: 6d016d5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
d09bd7b to
f711cd7
Compare
|
Would this be simpler to just put an Previously unsafe stuff was independent of bindings that are already in place. E.g. new experimental bindings or internal metadata to send up alongside the Worker. |
debdd3c to
83d6b1e
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it!
It's a shame that we can't do the merge at an earlier stage in the configuration validation, which would be cleaner and simpler, but I understand that the intermediate typings and transforms that are necessary don't support the fields that can appear in the unsafe field.
Add an
unsafe.containersfield to allow internal users to configure container options that we do not want to expose publicly (yet).This will skip wrangler-side validation, and all validation will be done by the containers control plane, which will check if everything is the right shape and you have the right capabilities to do whatever it is you're trying to do.