feat: experimental workers assets can be ignored by adding a .assetsignore file#6640
Merged
petebacondarwin merged 2 commits intomainfrom Sep 11, 2024
Merged
feat: experimental workers assets can be ignored by adding a .assetsignore file#6640petebacondarwin merged 2 commits intomainfrom
petebacondarwin merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 904218c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-wrangler-6640You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6640/npm-package-wrangler-6640Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-wrangler-6640 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-create-cloudflare-6640 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-cloudflare-kv-asset-handler-6640npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-miniflare-6640npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-cloudflare-pages-shared-6640npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-cloudflare-vitest-pool-workers-6640npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-cloudflare-workers-editor-shared-6640npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10737106861/npm-package-cloudflare-workers-shared-6640Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Contributor
|
We've previously tried to get away from the |
Contributor
Author
OK. I am onboard with that. @tanushree-sharma - do you agree? |
|
Yep, sounds good to me. |
petebacondarwin
changed the title
…cfassetsignore file
petebacondarwin
force-pushed
the
cf-assets-ignore
branch
from
00f3922 to
904218c
Compare
CarmenPopoviciu
approved these changes
Sep 11, 2024
Merged
andyjessop
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Add pipeline binding to wrangler.toml (#6674) Fix Pages duplicating hash in redirects (#6680) Bradley/r2 event notification get (#6652) feat(wrangler): Add support for placement hints (#6625) fix(wrangler): Validate `routes` for Workers with assets (#6621) chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates (#6673) chore(workers-shared): Configure GitHub Actions to deploy Asset Worker (#6542) feat: experimental workers assets can be ignored by adding a .assetsignore file (#6640)
methanoya
added a commit
to methanoya/sveltekit
that referenced
this pull request
Dec 5, 2024
6 tasks
teemingc
added a commit
to sveltejs/kit
that referenced
this pull request
Dec 19, 2024
* .assetsignore file generation for Cloudflare deployment. It is corresponded to cloudflare/workers-sdk#6640 * move .assetsignore to files folder * add .assetsignore file generation for adapter-cloudflare-workers * changeset update * move .gitignore per Ben McCann (benmccann) request * Update .changeset/proud-taxis-admire.md * Update .changeset/proud-taxis-admire.md Co-authored-by: Tee Ming <chewteeming01@gmail.com> * Revert "add .assetsignore file generation for adapter-cloudflare-workers" This reverts commit 0e9b1fc. * merge user's .assetsignore with the generated one * Update proud-taxis-admire.md remove mention of the unaffected package * add ending newline to the generated .assetsignore * move `.assetsignore` generation to generate_assetsignore() * simplify the change * cleanup unused import * Update .changeset/proud-taxis-admire.md --------- Co-authored-by: Timur Gamerov <methanoya@users.noreply.github.com> Co-authored-by: Tee Ming <chewteeming01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following