Skip to content

Fix mtls remtote binding warning #9988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

penalosa
Copy link
Contributor

Fixes #9928

mTLS bindings inadvertently had the wrong warning label.


  • Tests
    • Tests included
    • Tests not necessary because: minor output change
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a v3 feature

@penalosa penalosa requested a review from a team as a code owner July 16, 2025 15:16
Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: 34e95b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/mtls-remote-warning might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9988
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

Copy link

pkg-pr-new bot commented Jul 16, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9988

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9988

miniflare

npm i https://pkg.pr.new/miniflare@9988

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9988

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9988

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9988

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9988

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9988

wrangler

npm i https://pkg.pr.new/wrangler@9988

commit: 34e95b1

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 16, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 21, 2025
@emily-shen emily-shen merged commit 7fb0bfd into main Jul 23, 2025
41 of 43 checks passed
@emily-shen emily-shen deleted the penalosa/mtls-remote-warning branch July 23, 2025 12:52
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

experimental_remote: AI bindings warning printed if mtls_certificates binding used
3 participants