Skip to content

Upgrade js-yaml to avoid Denial of Service #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Upgrade js-yaml to avoid Denial of Service #39

merged 1 commit into from
Mar 25, 2019

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Mar 22, 2019

Based on the npm audit, there is an security issue with js-yaml, so upgrade to the latest version to fix.
And with the latest js-yaml version, all the test cases can still pass.

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the PR!

@pmuellr pmuellr merged commit 3f19f12 into cloudfoundry-community:master Mar 25, 2019
@pmuellr
Copy link
Member

pmuellr commented Mar 25, 2019

Now available on npm as version 1.2.1 - https://www.npmjs.com/package/cfenv

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants