Skip to content

Fix deleting stemcell faild error #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaozhu36 merged 1 commit into from
Jan 6, 2019
Merged

Fix deleting stemcell faild error #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ IMPROVEMENTS

BUG FIXES

- Fix creating vm IdempotentProcessing and add sync lock for client ([#44](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/44))
- Fix deleting stemcell faild error ([#53](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/53))
- Fix creating vm IdempotentProcessing and add sync lock for client ([#52](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/52))
- Fix full stemcell create flow ([#50](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/50))
- Fix bosh CPI to use https based communication instead of http ([#48](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/48))
- Fix DeleteWithInstance not working bug ([#46](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/46))
- Fix upload stemcell bug and upgrade oss sdk version ([#42](https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/42))

Expand Down
17 changes: 3 additions & 14 deletions src/bosh-alicloud-cpi/action/delete_stemcell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,9 @@ func NewDeleteStemcellMethod(cc CallContext, stemcells alicloud.StemcellManager)
}

func (a DeleteStemcellMethod) DeleteStemcell(cid apiv1.StemcellCID) error {
//
// NOTHING TO DELETE

//stemcell, found, err := a.runner.FindStemcellId(cid)
//if err != nil {
// return bosherr.WrapErrorf(err, "Finding stemcell '%s'", cid)
//}
//
//if found {
// err := stemcell.Delete()
// if err != nil {
// return bosherr.WrapErrorf(err, "Deleting stemcell '%s'", cid)
// }
//}
if err := a.stemcells.DeleteStemcell(cid.AsString()); err != nil {
return a.WrapErrorf(err, "Deleting stemcell '%s'", cid)
}

return nil
}