App and service metadata #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Hey petko-boyadzhiev! All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process. The following github user @petko-boyadzhiev is not covered by a CLA. After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s). |
|
Hi, @twoseat |
|
Thanks for the PR @petko-boyadzhiev (and apologies for the delay merging). I tweaked some formatting and other details to fit with our conventions, but nothing major. Look for a release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve some of the requirements of
Issue link: https://github.com/cloudfoundry/cf-java-client/issues/946
It adds support for application and service-instance metadata. Also it adds the possibility for service-instance to be modified (required by the metadata task).
Please note that extensive testing on real CF is currently in progress, so i will notify here when it can be merged (if all other things are ok).