This repository was archived by the owner on Apr 30, 2025. It is now read-only.
fix: do not retry if context has been cancelled #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmoehl
force-pushed
the
dont-retry-on-context-cancel
branch
from
9983c22 to
5308c3f
Compare
|
This fix should address the issues reported in the linked Slack thread. Nevertheless we should make the classifier lists distinct and re-consider under which circumstances an endpoint should be removed from the pool, but this is out of scope for this PR. |
|
Running the full unit test suite in docker fails because the image is gone: |
maxmoehl
commented
May 8, 2023
maxmoehl
force-pushed
the
dont-retry-on-context-cancel
branch
from
5308c3f to
9025068
Compare
The additional retry logic introduced by cloudfoundry#337 caused any error to become retry-able if the request did not make it to the back end. This included errors that came from context cancellation. This commit makes requests non-retry-able as soon as the context has been cancelled. Co-Authored-By: Dominik Froehlich <[email protected]>
maxmoehl
force-pushed
the
dont-retry-on-context-cancel
branch
from
9025068 to
a3bd9ab
Compare
geofffranks
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional retry logic introduced by #337 caused any error to become retry-able if the request did not make it to the back end. This included errors that came from context cancellation. This commit makes requests non-retry-able as soon as the context has been cancelled.
See related Slack discussion: https://cloudfoundry.slack.com/archives/C01ABMVNE9E/p1683313910835329
mainbranchscripts/run-unit-tests-in-dockerfrom routing-release.