Skip to content

Cobmine all Korifi controllers into one deployment #4185

@georgethebeatle

Description

@georgethebeatle

Background

As of today controllers are split into serveral deployments like statefulset-runner, kpack-builder, job-task-runner. This is not necessary and causes some pain when it comes to maintaining the Dockerfiles and generating webhook certificates.

The separation was done so that controllers can be scaled independently and so that rbac permissions are more fine grain. However we haven't really taken advantage of this so far.

Action to take

Merge all controllers back into a single deployment.

Dev Notes

  • We should keep the current helm value as much as possible structure to avoid breaking changes
  • We should keep the ability to opt out of some controllers (e.g. statefulset runner). This will be a conditional branch in the common controllers main
  • We should squash controllers Dockerfiles back into one
  • We should squash webhook cert values into one
  • Essentially a revert of Extract optional components into deployments #3712

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions