[Bug]: cf rename-space not working

[benjaminguttmann-avtq]

What happened?

Hi,

when trying to use the cf rename-space command for Korifi it ends up in an error.

cf rename-space bg-org bg-space
Renaming space bg-org to bg-space as cf-admin...
invalid request body: json: unknown field "name"
FAILED

detailed output

cf rename-space bg-org bg-space -v
REQUEST: [2025-11-25T10:40:23+01:00]
GET /whoami HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: 868d04629805d3f4
X-B3-Traceid: 0cb5428ad0ac46bc9bf6ceb280697e26
[application/json Content Hidden]

RESPONSE: [2025-11-25T10:40:23+01:00]
HTTP/1.1 200 OK
Content-Length: 34
Content-Type: application/json
Date: Tue, 25 Nov 2025 09:40:23 GMT
X-Correlation-Id: e43556c0-79d4-4376-a600-ea0f15f1f3c3
{
  "kind": "User",
  "name": "cf-admin"
}


Renaming space bg-org to bg-space as cf-admin...
REQUEST: [2025-11-25T10:40:23+01:00]
GET /v3/spaces?names=bg-org&organization_guids=487c0792-9b3f-4b48-9c3a-d7c492b8e1cc&page=1&per_page=1 HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: 556c9957fc242024
X-B3-Traceid: 0cb5428ad0ac46bc9bf6ceb280697e26
[application/json Content Hidden]

RESPONSE: [2025-11-25T10:40:23+01:00]
HTTP/1.1 200 OK
Content-Length: 1296
Content-Type: application/json
Date: Tue, 25 Nov 2025 09:40:23 GMT
X-Correlation-Id: ae791719-e7f3-4e08-95c4-d75593802940
{
  "pagination": {
    "first": {
      "href": "https://localhost:443/v3/spaces?names=bg-org&organization_guids=487c0792-9b3f-4b48-9c3a-d7c492b8e1cc&page=1&per_page=1"
    },
    "last": {
      "href": "https://localhost:443/v3/spaces?names=bg-org&organization_guids=487c0792-9b3f-4b48-9c3a-d7c492b8e1cc&page=1&per_page=1"
    },
    "next": null,
    "previous": null,
    "total_pages": 1,
    "total_results": 1
  },
  "resources": [
    {
      "created_at": "2025-11-25T09:40:01Z",
      "guid": "b55881fa-6de6-470b-b132-2534da17595c",
      "links": {
        "organization": {
          "href": "https://localhost:443/v3/organizations/487c0792-9b3f-4b48-9c3a-d7c492b8e1cc"
        },
        "self": {
          "href": "https://localhost:443/v3/spaces/b55881fa-6de6-470b-b132-2534da17595c"
        }
      },
      "metadata": {
        "annotations": {
          "korifi.cloudfoundry.org/creation-version": "0.13.1-557-gbf1fd0cd"
        },
        "labels": {
          "korifi.cloudfoundry.org/created_at": "2025-11-25T09-40-01",
          "korifi.cloudfoundry.org/guid": "b55881fa-6de6-470b-b132-2534da17595c",
          "korifi.cloudfoundry.org/org-guid": "487c0792-9b3f-4b48-9c3a-d7c492b8e1cc",
          "korifi.cloudfoundry.org/ready": "True",
          "korifi.cloudfoundry.org/space-name": "e3ed64b7e0428ec08da68e9c0b29073a6ed7ac10d7ff54e95007a90e",
          "korifi.cloudfoundry.org/updated_at": "2025-11-25T09-40-01"
        }
      },
      "name": "bg-org",
      "relationships": {
        "organization": {
          "data": {
            "guid": "487c0792-9b3f-4b48-9c3a-d7c492b8e1cc"
          }
        }
      },
      "updated_at": "2025-11-25T09:40:01Z"
    }
  ]
}


REQUEST: [2025-11-25T10:40:23+01:00]
PATCH /v3/spaces/b55881fa-6de6-470b-b132-2534da17595c HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: 35f64e816b508bf5
X-B3-Traceid: 0cb5428ad0ac46bc9bf6ceb280697e26
{
  "name": "bg-space"
}


RESPONSE: [2025-11-25T10:40:23+01:00]
HTTP/1.1 422 Unprocessable Entity
Content-Length: 123
Content-Type: application/json
Date: Tue, 25 Nov 2025 09:40:23 GMT
X-Correlation-Id: a007143a-1143-4f02-a402-8f4135994653
{
  "errors": [
    {
      "code": 10008,
      "detail": "invalid request body: json: unknown field \"name\"",
      "title": "CF-UnprocessableEntity"
    }
  ]
}


invalid request body: json: unknown field "name"
FAILED

What you expected to happen

The space gets renamed

Acceptance Criteria

GIVEN I have a space within an organization
WHEN I run cf rename-space <old_space_name> <new_space_name>
THEN I can see that the space name has changed to new_space_name

How to reproduce it (as minimally and precisely as possible)

cf create-org test-org
cf t -o test-org
cf create-space test-space
cf rename-space test-space test-space2

Anything else we need to know?

No response

Environment

Revision of codebase: commit bf1fd0c
Kubernetes version (use kubectl version):

kubectl version
Client Version: v1.31.5
Kustomize Version: v5.4.2
Server Version: v1.31.0

Cloud provider or hardware configuration: Kind
Others:

[danail-branekov]

As discussed over slack, in order to support space renaming it should be enough to support the name field on the PATCH /v3/spaces/<space-guid> endpoint and set the CFSpace.Spec.DisplayName field in the space repository. The change does not need to validate space name uniqueness - the space webhook already validates that on create and update.

By implementing this, we should start supporting the cf rename-space command, so a smoke test that exercises that command should be introduced as well.

@benjaminguttmann-avtq would you give a try PRing this?

PS: setting the display name for orgs seems to be already in place, you could look there for inspiration

[benjaminguttmann-avtq]

@danail-branekov yes, please assign me to this