[Feature]: As a Korifi user I can run `cf rename-org <org_name> <new_org_name>`

[benjaminguttmann-avtq]

Blockers/Dependencies

No response

Background

cf rename-org bg-org bg-org2
Renaming org bg-org to bg-org2 as cf-admin...
invalid request body: json: unknown field "suspended"
FAILED

detailed info

cf rename-org bg-org bg-org2 -v
REQUEST: [2025-11-25T11:01:48+01:00]
GET /whoami HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: a05160b6f13f4f93
X-B3-Traceid: e5ef6e7ee04642968199aac8d5fc7f52
[application/json Content Hidden]

RESPONSE: [2025-11-25T11:01:48+01:00]
HTTP/1.1 200 OK
Content-Length: 34
Content-Type: application/json
Date: Tue, 25 Nov 2025 10:01:48 GMT
X-Correlation-Id: 8df7211b-98fb-4faf-a08b-3f1f27427867
{
  "kind": "User",
  "name": "cf-admin"
}


Renaming org bg-org to bg-org2 as cf-admin...
REQUEST: [2025-11-25T11:01:48+01:00]
GET /v3/organizations?names=bg-org&page=1&per_page=1 HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: 1f88a4cb043a1bbd
X-B3-Traceid: e5ef6e7ee04642968199aac8d5fc7f52
[application/json Content Hidden]

RESPONSE: [2025-11-25T11:01:48+01:00]
HTTP/1.1 200 OK
Content-Length: 1180
Content-Type: application/json
Date: Tue, 25 Nov 2025 10:01:48 GMT
X-Correlation-Id: c540fd04-dfe4-4ba9-8fe0-8e466519abfc
{
  "pagination": {
    "first": {
      "href": "https://localhost:443/v3/organizations?names=bg-org&page=1&per_page=1"
    },
    "last": {
      "href": "https://localhost:443/v3/organizations?names=bg-org&page=1&per_page=1"
    },
    "next": null,
    "previous": null,
    "total_pages": 1,
    "total_results": 1
  },
  "resources": [
    {
      "created_at": "2025-11-25T09:39:55Z",
      "guid": "487c0792-9b3f-4b48-9c3a-d7c492b8e1cc",
      "links": {
        "default_domain": {
          "href": "https://localhost:443/v3/organizations/487c0792-9b3f-4b48-9c3a-d7c492b8e1cc/domains/default"
        },
        "domains": {
          "href": "https://localhost:443/v3/organizations/487c0792-9b3f-4b48-9c3a-d7c492b8e1cc/domains"
        },
        "self": {
          "href": "https://localhost:443/v3/organizations/487c0792-9b3f-4b48-9c3a-d7c492b8e1cc"
        }
      },
      "metadata": {
        "annotations": {
          "korifi.cloudfoundry.org/creation-version": "0.13.1-557-gbf1fd0cd"
        },
        "labels": {
          "korifi.cloudfoundry.org/created_at": "2025-11-25T09-39-55",
          "korifi.cloudfoundry.org/guid": "487c0792-9b3f-4b48-9c3a-d7c492b8e1cc",
          "korifi.cloudfoundry.org/org-name": "e3ed64b7e0428ec08da68e9c0b29073a6ed7ac10d7ff54e95007a90e",
          "korifi.cloudfoundry.org/ready": "True",
          "korifi.cloudfoundry.org/updated_at": "2025-11-25T09-39-55"
        }
      },
      "name": "bg-org",
      "suspended": false,
      "updated_at": "2025-11-25T09:39:55Z"
    }
  ]
}


REQUEST: [2025-11-25T11:01:48+01:00]
PATCH /v3/organizations/487c0792-9b3f-4b48-9c3a-d7c492b8e1cc HTTP/1.1
Host: localhost
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: cf8/8.14.1+2bcb856.2025-06-10 (go1.24.3; arm64 darwin)
X-B3-Spanid: ee40d66bc18eaec9
X-B3-Traceid: e5ef6e7ee04642968199aac8d5fc7f52
{
  "metadata": {
    "annotations": {
      "korifi.cloudfoundry.org/creation-version": "0.13.1-557-gbf1fd0cd"
    },
    "labels": {
      "korifi.cloudfoundry.org/created_at": "2025-11-25T09-39-55",
      "korifi.cloudfoundry.org/guid": "487c0792-9b3f-4b48-9c3a-d7c492b8e1cc",
      "korifi.cloudfoundry.org/org-name": "e3ed64b7e0428ec08da68e9c0b29073a6ed7ac10d7ff54e95007a90e",
      "korifi.cloudfoundry.org/ready": "True",
      "korifi.cloudfoundry.org/updated_at": "2025-11-25T09-39-55"
    }
  },
  "name": "bg-org2",
  "suspended": false
}


RESPONSE: [2025-11-25T11:01:48+01:00]
HTTP/1.1 422 Unprocessable Entity
Content-Length: 128
Content-Type: application/json
Date: Tue, 25 Nov 2025 10:01:48 GMT
X-Correlation-Id: 94f823d7-7f6d-4f42-9b4f-4d99fe6a7f1a
{
  "errors": [
    {
      "code": 10008,
      "detail": "invalid request body: json: unknown field \"suspended\"",
      "title": "CF-UnprocessableEntity"
    }
  ]
}


invalid request body: json: unknown field "suspended"
FAILED

Acceptance Criteria

GIVEN a CF org
WHEN I run cf rename-org <org_name> <new_org_name>
THEN I the org should be renamed to <new_org_name>

Dev Notes

No response

[danail-branekov]

It seems that changing the org name is already supported. In order to get the command working, it seems sufficient to just allow the suspended field on the PATCH /v3/organizations/<org-guid> endpoint and just ignore the value.

As such a fix would start supporting the rename-org command, a smoke test that exercises the command should be introduced as well.

@benjaminguttmann-avtq would you try PRing this?

[benjaminguttmann-avtq]

@danail-branekov please assign me to this

It seems like adding the suspended field is not enough, after doing so and trying to rename the org it fails with the following error:

metadata.annotations.korifi.cloudfoundry.org/creation-version label/annotation key cannot use the cloudfoundry.org domain, metadata.labels.korifi.cloudfoundry.org/created_at label/annotation key cannot use the cloudfoundry.org domain, metadata.labels.korifi.cloudfoundry.org/guid label/annotation key cannot use the cloudfoundry.org domain, metadata.labels.korifi.cloudfoundry.org/org-name label/annotation key cannot use the cloudfoundry.org domain, metadata.labels.korifi.cloudfoundry.org/ready label/annotation key cannot use the cloudfoundry.org domain, metadata.labels.korifi.cloudfoundry.org/updated_at label/annotation key cannot use the cloudfoundry.org domain

{"severity":"INFO","timestamp":"2025-11-28T10:42:28.517621378Z","logger":"handlers.org.update","caller":"errors/errors.go:32","message":"failed to decode payload","correlation-id":"edefbc65-d003-4142-bc82-d0d1fdce1541","reason":"metadata: (annotations: (korifi.cloudfoundry.org/creation-version: label/annotation key cannot use the cloudfoundry.org domain.); labels: (korifi.cloudfoundry.org/created_at: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/guid: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/org-name: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/ready: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/updated_at: label/annotation key cannot use the cloudfoundry.org domain.).)."}
{"severity":"INFO","timestamp":"2025-11-28T10:42:28.517719878Z","caller":"routing/handler.go:47","message":"handler returned error","correlation-id":"edefbc65-d003-4142-bc82-d0d1fdce1541","reason":"metadata: (annotations: (korifi.cloudfoundry.org/creation-version: label/annotation key cannot use the cloudfoundry.org domain.); labels: (korifi.cloudfoundry.org/created_at: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/guid: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/org-name: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/ready: label/annotation key cannot use the cloudfoundry.org domain; korifi.cloudfoundry.org/updated_at: label/annotation key cannot use the cloudfoundry.org domain.).)."}

[benjaminguttmann-avtq]

https://github.com/benjaminguttmann-avtq/korifi/tree/4245-fix-org-renaming

[danail-branekov]

oh, yeah, I remember modification on those metadata keys has been rejected on purpose, cannot remember the context why though