[Bug]: containerRepositoryPrefix value is missing in values.yaml but is required by schema validation

[vkazmin1]

What happened?

Hi team,

I've mentioned that containerRepositoryPrefix is not defined in helm values, but is still required by schema validation.

I removed containerRepositoryPrefix from helm values.yaml since I couldn't find it in the list of variables, and then the issue happened:

values don't meet the specifications of the schema(s) in the following chart(s): korifi: - (root): containerRepositoryPrefix is required

I didn't dive deep to figure out by myself, but I think either schema validation is outdated or values.yaml

Do we actually need containerRepositoryPrefix?

What you expected to happen

helm chart is fixed.

How to reproduce it (as minimally and precisely as possible)

remove containerRepositoryPrefix from values.yaml while applying helm chart.

Korifi v0.17.0

[danail-branekov]

Yes, we do need this property for the api and controllers configs.

This value must be set - it configures the container registry Korifi uses to push build droplets to. Therefore I would suggest a fix where:
a) we declare that value into values.yaml to make helm users aware of such a property
b) make that value required in the api and controllers configmaps templates (here is an example of a required template value)

Would you be interested into PR-ing such a fix?

[vkazmin1]

Yes, we do need this property for the api and controllers configs.

This value must be set - it configures the container registry Korifi uses to push build droplets to. Therefore I would suggest a fix where: a) we declare that value into values.yaml to make helm users aware of such a property b) make that value required in the api and controllers configmaps templates (here is an example of a required template value)

Would you be interested into PR-ing such a fix?

alright, I can prepare the PR to fix it.

[vkazmin1]

@danail-branekov
prepared PR: #4249