This repository was archived by the owner on Apr 29, 2025. It is now read-only.
feat: Implement protocol field #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
b1tamara
commented
Apr 28, 2023
b1tamara
commented
- Related to issue: route-registrar: support for publishing HTTP/2 routes routing-release#320.
- The PR adds an additional field to the route configuration called 'protocol' which can be set to 'http1' or 'http2' or left empty to support http2 routes. The field is also included in the route that is announced to gorouter.
- Additional tests for the new field.
maxmoehl
force-pushed
the
implement-protocol-field
branch
from
2b22369 to
0d865b3
Compare
domdom82
suggested changes
May 4, 2023
| Expect(registryMessage.URIs).To(Equal(expectedRegistryMessage.URIs)) | ||
| Expect(registryMessage.Port).To(Equal(expectedRegistryMessage.Port)) | ||
| Expect(registryMessage.RouteServiceUrl).To(Equal(expectedRegistryMessage.RouteServiceUrl)) | ||
| Expect(registryMessage.Tags).To(Equal(expectedRegistryMessage.Tags)) |
There was a problem hiding this comment.
shouldn't we check for the protocol here?
To support http2 routes, this commit adds an additional field to the route configuration called `protocol` which can be set to `http` or `http2` (or left empty). The field is also included in the route that is announced to gorouter. Co-Authored-By: Tamara Boehm <[email protected]> Resolves: cloudfoundry/routing-release#320
b1tamara
force-pushed
the
implement-protocol-field
branch
from
0d865b3 to
a2045db
Compare
geofffranks
approved these changes
May 8, 2023
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.