Remove SAML IDP feature #2638
Merged
Remove SAML IDP feature #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186632650 The labels on this github issue will be updated when the story is started. |
Tallicia
added
in-flight
in progress
DO NOT MERGE
hsinn0
force-pushed
the
saml-lib-replacement-182118433
branch
from
a7f4f5a to
dc428b5
Compare
swalchemist
force-pushed
the
saml-lib-replacement-182118433
branch
2 times, most recently
from
804dd95 to
aa60f2c
Compare
hsinn0
force-pushed
the
saml-lib-replacement-182118433
branch
2 times, most recently
from
07271e7 to
8507289
Compare
peterhaochen47
force-pushed
the
saml-lib-replacement-182118433
branch
3 times, most recently
from
9b047f7 to
07c38ee
Compare
* Comment out / delete code to get the project to work * status: all unit tests passing (./gradlew test), local server starts (./gradlew run) successfully with the UAA login page working in browser [#182118433] Co-authored-by: Alicia Yingling <[email protected]> Co-authored-by: Bruce Ricard <[email protected]> Co-authored-by: Danny Faught <[email protected]> Co-authored-by: Peter Chen <[email protected]>
[#182118433] Co-authored-by: Bruce Ricard <[email protected]>
[#182118433] Co-authored-by: Bruce Ricard <[email protected]>
[#182118433] Co-authored-by: Bruce Ricard <[email protected]>
[#182118433] Co-authored-by: Bruce Ricard <[email protected]>
- Changed the doc test to use mocked-up data instead of making actual calls to the end-point that does not exist anymore. [#182118433] Co-authored-by: Alicia Yingling <[email protected]>
- The unit test was testing the idp endpoint which is removed, so the test is now removed. [#182118433] Co-authored-by: Hongchol Sinn <[email protected]>
- Disabled/removed test cases that depend on the removed SAML IDP feature. [#182118433] Co-authored-by: Bruce Ricard <[email protected]>
- Replaced the use of the removed SAML IDP endpoint call with mockup data. - Also, some clean-ups and refactoring [#182118433] Co-authored-by: Hongchol Sinn <[email protected]> Co-authored-by: Danny Faught <[email protected]> Co-authored-by: Bruce Ricard <[email protected]> Co-authored-by: Alicia Yingling <[email protected]>
- The integration test was getting the IDP metadata from actual UAA server, which needs be bypassed as UAA does not have the SAML IDP endpoint anymore. - With that, the existing integration test basically becomes the same as `TokenEndpointDocs.getTokenUsingSaml2BearerGrant()`. - So removed the existing integration test cases and created a new mock mvc test based on the `TokenEndpointDocs` code. [#182118433] Co-authored-by: Bruce Ricard <[email protected]>
- These inputs to the parameterized tests are testing "/saml/idp/metadata" endpoint which has been removed [#182118433] Co-authored-by: Peter Chen <[email protected]>
- the logic being tested in these two tests are already covered by Saml2BearerGrantMockMvcTests - since UAA-as-a-SAML-IDP feature has been removed, the difference between these two tests (same zone vs two zones) do not matter so they can both be covered by Saml2BearerGrantMockMvcTests [#182118433] Co-authored-by: Peter Chen <[email protected]>
- this 3 lines have no bearing on these 2 tests Co-authored-by: Peter Chen <[email protected]>
- to clarify things - and correct wrong comments [#182118433] Co-authored-by: Peter Chen <[email protected]>
Tallicia
added
DO NOT MERGE
hsinn0
removed
in progress
DO NOT MERGE
strehle
reviewed
Jan 18, 2024
Member
strehle
left a comment
strehle
left a comment
There was a problem hiding this comment.
Check and change Readme notice but the rest LGTM
Member
|
As mentioned in slack , please wait until release 76.31.0, then merge this PR and increase major version, thanks |
swalchemist
suggested changes
Jan 18, 2024
- Remove the added section about the removed feature as that should be just mentioned in release notes. [#182118433]
Contributor
Author
Done |
swalchemist
approved these changes
Jan 18, 2024
strehle
approved these changes
Jan 19, 2024
peterhaochen47
added a commit
that referenced
this pull request
Feb 1, 2024
- This table was added for the UAA-as-SAML-IDP feature (b93c87a) - This feature has been removed: #2638. Hence this table is now unused. - The "DROP TABLE IF EXISTS" syntax would not error out if the table does not exist, compared to just "DROP TABLE". - Also clean up docs and a test util that reference this table. [#182118433]
peterhaochen47
added a commit
that referenced
this pull request
Feb 6, 2024
- This table was added for the UAA-as-SAML-IDP feature (b93c87a) - This feature has been removed: #2638. Hence this table is now unused. - The "DROP TABLE IF EXISTS" syntax would not error out if the table does not exist, compared to just "DROP TABLE". - Also clean up docs and a test util that reference this table. [#182118433]
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approve or disapprove but do not merge to develop yet.We want merge this todevelopnow. As this is a breaking change,we have to decide which UAA version this change should go with.we also want to bump UAA major version after the merge.