-
Notifications
You must be signed in to change notification settings - Fork 3
Add styles for WordPress embed block #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
🦋 Changeset detectedLatest commit: 6dbf13f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Just discovered an oversight in this: The margin enhancements should only apply to specific types of embeds (not Twitter, for example). Updating. |
I made a few changes:
|
What does this mean? |
Video embeds will attempt to fill the container margins where possible. I'm open to suggestions on how better to explain it, I'm drawing a blank right now. |
Overview
I attempted to embed a YouTube video using the WordPress "embed" block, but was surprised to see it didn't really apply any meaningful styles. This PR changes that so it will have parity with our other media blocks.
(I also removed usage of the deprecated
defaultValue
property from one of the other demos in the same file.)Screenshots
Testing
On the deploy preview, try out: