Fix for overflow scrolling issue #2275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses an issue where code blocks in comments could break the page's horizontal scroll.
Screenshots
Before, you can scroll the document horizontally as far as the overflow content, even though it's clipped by the
<pre>
element. After, horizontal scrolling is only applied to the<pre>
.Testing
I tried, I really tried, to add a test story to this repository. But because the issue's only symptomatic in a comment thread when the
syntax-highlighting-code-block
is applied within a full page, it was going to take me a lot more time to recreate in a story.You can recreate the fix by visiting https://cloudfour.com/thinks/css-circles/#comment-6111 in a Chromium browser, resizing to a narrow width, inspecting the
<pre>
element, and applyingposition: relative
to the existingpre
block of styles.Other than that, a review of existing
<pre>
patterns on the deploy preview seems like a good idea. That includes: