Conversation
gitops-for-cloudnativedays
bot
added
the
reviewapps
takaishi
force-pushed
the
fix-speaker-announcement
branch
from
088887a to
df58055
Compare
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
commit: cloudnativedaysjp/dreamkast@088887a action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/14957181415 Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
takaishi
force-pushed
the
fix-speaker-announcement
branch
from
df58055 to
9053566
Compare
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
commit: cloudnativedaysjp/dreamkast@df58055 action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/14957185606 Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 11, 2025
commit: cloudnativedaysjp/dreamkast@9053566 action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/14957191223 Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
Consolidated the logic for determining speaker IDs into a new `speaker_ids` method. This change reduces duplication in the `create` and `update` actions, improving code clarity and maintainability.
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 12, 2025
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
May 12, 2025
commit: cloudnativedaysjp/dreamkast@079c40a action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/14962865592 Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
Simplecov Report
|
takaishi
changed the title
only_accepted
jacopen
approved these changes
May 14, 2025
Collaborator
|
LGTM Draft PRなのでマージせずにおいてる |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.