Skip to content

Proposal詳細表示のnil参照による500エラーを修正#2752

Merged
takaishi merged 1 commit intomainfrom
fix/proposal-show-nil-guard
Mar 11, 2026
Merged

Proposal詳細表示のnil参照による500エラーを修正#2752
takaishi merged 1 commit intomainfrom
fix/proposal-show-nil-guard

Conversation

@takaishi
Copy link
Contributor

@takaishi takaishi commented Mar 11, 2026 •
edited
Loading

概要

ProposalsController#show で @proposal が見つからない場合に @proposal.talk を呼んで NoMethodError になる問題を修正しました。

修正内容

  • ProposalsController#show の取得処理を find_by! に変更
    • conference / proposal が未存在の場合は 500 ではなく 404 を返却
  • スピーカーダッシュボードのセッション一覧で、talk.proposal が存在する場合のみ proposal リンクを表示
    • talk.proposal.id の nil 参照を防止

影響

  • proposal 不整合データや不正URLアクセス時の 500 を回避
  • 通常フロー（proposal が存在する場合）の表示・動作は従来どおり

@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Mar 11, 2026
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Mar 11, 2026
@gitops-for-cloudnativedays
Bump docker tag by cloudnativedaysjp/dreamkast#2752
e17091b 
commit: cloudnativedaysjp/dreamkast@009b1f0
action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/22957442320
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Mar 11, 2026
@gitops-for-cloudnativedays
Bump docker tag by cloudnativedaysjp/dreamkast#2752 (#5218)
5c3c0eb 
commit: cloudnativedaysjp/dreamkast@009b1f0
action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/22957442320

Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Review app

@takaishi takaishi changed the title Guard proposal show and talk proposal link against nil Proposal詳細表示のnil参照による500エラーを修正 Mar 11, 2026
@takaishi takaishi marked this pull request as ready for review March 11, 2026 14:26
@takaishi takaishi requested a review from a team March 11, 2026 14:26
@takaishi takaishi self-assigned this Mar 11, 2026
@takaishi takaishi merged commit 2fa618e into main Mar 11, 2026
10 of 11 checks passed
@takaishi takaishi deleted the fix/proposal-show-nil-guard branch March 11, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@takaishi takaishi

Labels

reviewapps Build ReviewApp environment automatically if this label is granted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@takaishi