Skip to content

talk.track が nil の場合に Talks 詳細で落ちる不具合を修正#2760

Merged
jacopen merged 1 commit intomainfrom
fix/talk-track-nil-guard
Mar 15, 2026
Merged

talk.track が nil の場合に Talks 詳細で落ちる不具合を修正#2760
jacopen merged 1 commit intomainfrom
fix/talk-track-nil-guard

Conversation

@takaishi
Copy link
Contributor

@takaishi takaishi commented Mar 14, 2026

概要

  • talk.track が欠けている場合に発生する undefined method name for nil を防止
  • Talks 詳細画面の partial で talk.track.name を安全に参照するよう修正

変更内容

  • app/views/talks/partial_show/_col_other_talks.erb
    • talk.track が存在する場合のみ Track 表示を行うように変更
  • app/views/talks/partial_show/_col_main_pane.html.erb
    • 同様のガードを追加して同経路の例外を防止

影響

  • Track 未設定データを含むセッションでも Talks 詳細画面が 500 エラーにならない
  • 日付・時刻の表示ロジックは従来どおり

テスト

  • 未実施(ビューの nil ガード追加のみ)

@gitops-for-cloudnativedays gitops-for-cloudnativedays bot added the reviewapps Build ReviewApp environment automatically if this label is granted label Mar 14, 2026
gitops-for-cloudnativedays bot added a commit to cloudnativedaysjp/dreamkast-infra that referenced this pull request Mar 14, 2026
commit: cloudnativedaysjp/dreamkast@32708df
action URL: https://github.com/cloudnativedaysjp/dreamkast/actions/runs/23076068733

Co-authored-by: gitops-for-cloudnativedays[bot] <113280573+gitops-for-cloudnativedays[bot]@users.noreply.github.com>
@github-actions
Copy link

@github-actions
Copy link

Simplecov Report

Covered Threshold
65.94% 60%

@takaishi takaishi changed the title Fix nil track guard in talks show views Fix talks show crash when talk track is nil Mar 14, 2026
@takaishi takaishi changed the title Fix talks show crash when talk track is nil talk.track が nil の場合に Talks 詳細で落ちる不具合を修正 Mar 14, 2026
@takaishi takaishi marked this pull request as ready for review March 15, 2026 09:37
@takaishi takaishi requested a review from a team March 15, 2026 09:37
@jacopen jacopen merged commit 2763097 into main Mar 15, 2026
12 checks passed
@jacopen jacopen deleted the fix/talk-track-nil-guard branch March 15, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewapps Build ReviewApp environment automatically if this label is granted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants