Feature: Override S3 replication IAM role name + auto-add KMS perms#281
Open
kyogendra08 wants to merge 1 commit intocloudposse:mainfrom
Open
Feature: Override S3 replication IAM role name + auto-add KMS perms#281kyogendra08 wants to merge 1 commit intocloudposse:mainfrom
kyogendra08 wants to merge 1 commit intocloudposse:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
These are the problems encountered :
Replication role name is hardcoded to format("%s-replication", local.bucket_name), which breaks org naming policies.
With SSE-KMS buckets, replication needs KMS permissions that aren’t added by default in the replication IAM role.
why
Add variable s3_replication_iam_role_name to customize the role name
When sse_kms_encrypted_objects is enabled in s3 replication rules, KMS actions are added to the replication role (recursively if multiple buckets and kms keys are mentioned):
eg: kms:Encrypt, kms:Decrypt, kms:ReEncrypt*, kms:GenerateDataKey*, kms:DescribeKey
references
closes #279