Skip to content

chore: Add iconAriaLabel property to BaseOption interface #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Add iconAriaLabel property to BaseOption interface #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pages/select/screenshot.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ import ScreenshotArea from '../utils/screenshot-area';

const options: SelectProps.Options = [
{ value: 'first', label: 'Simple' },
{ value: 'second', label: 'With small icon', iconName: 'folder' },
{ value: 'second', label: 'With small icon', iconAriaLabel: 'folder icon alt label', iconName: 'folder' },
{
value: 'third',
label: 'With big icon icon',
description: 'Very big option',
iconAriaLabel: 'very big option icon alt label',
iconSvg: (
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" focusable="false">
<circle cx="8" cy="8" r="7" />
Expand Down
Loading
Loading