fix: [Duplicate to run workflows and deploy] Fix off-center popover flash when clicking CopyToClipboard #3461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the clipboard API is async, the popover briefly renders in the "pending" state before rendering in the "success" or "error" state, which is perceived as a visual glitch. The fix here is to wait to open the popover until we're out of the "pending" state. To achieve that, I've modified the `InternalPopover` API so that it doesn't render a popover if the given `content` is `null`, regardless of its internal `visible` state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the clipboard API is async, the popover briefly renders in the "pending" state before rendering in the "success" or "error" state, which is perceived as a visual glitch.
The fix here is to wait to open the popover until we're out of the "pending" state. To achieve that, I've modified the
InternalPopoverAPI so that it doesn't render a popover if the givencontentisnull, regardless of its internalvisiblestate.Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.