chore: Fix one of two animation issues #3510
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ape-design/components into explore-drawer-animation
…lore-drawer-animation
at-susie
requested review from
gethinwebster and
georgylobko
and removed request for
a team and
gethinwebster
georgylobko
reviewed
May 15, 2025
georgylobko
reviewed
May 15, 2025
An error occurred while trying to automatically change base from
feat/expandable-drawer
to
main
May 21, 2025 07:55
georgylobko
reviewed
May 21, 2025
| @@ -75,7 +75,7 @@ function AppLayoutGlobalDrawerImplementation({ | |||
| (isExpandedPrevious && !isExpanded); | |||
|
|
|||
| return ( | |||
| <Transition nodeRef={drawerRef} in={show || isExpanded} appear={show || isExpanded} timeout={0}> | |||
| <Transition nodeRef={drawerRef} in={show || isExpanded} appear={show || isExpanded} timeout={60}> | |||
There was a problem hiding this comment.
Can we do this using unmountOnExit?
There was a problem hiding this comment.
The unmountOnExit doesn't seem to help. As long as we keep timeout={0}, the Transition component instantly becomes exited state where we cannot have smooth exiting motion.
| display: block; | ||
| border-inline-start: none; | ||
| > .global-drawer-wrapper { | ||
| opacity: 0; |
There was a problem hiding this comment.
We need to do is to unmount the drawer after exiting the animation. How these styles help us achieving this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an animation issue for global-drawer.
We would like to have a smooth transition when a drawer is being closed.
Before this change, the style
drawer-hiddenwas added immediately when a close button is clicked, which was one of the two reasons for the unwanted sudden closing behavior. To address this, I added additional condition like below to make sure only after the Transition's component state becomesexited.:[styles['drawer-hidden']]: !show && state === 'exited',And I updated relevant styles accordingly.
Secondly, the
.global-toolsselector in the skeleton was set toinline-size: 0pxwhen panels are closed without any transition, which was another reason for the unwanted behavior.Issue-2.mp4
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.