Skip to content

feat: Implementation of the Button component Style API. #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

DaemonCahill
Copy link
Member

This PR implements the core Style API for the Button component.

@DaemonCahill DaemonCahill changed the title Implementation of Button component Style API. feat: Implementation of the Button component Style API. May 27, 2025
@DaemonCahill DaemonCahill force-pushed the scottob-button-style-api branch from 9d989c5 to fe4b972 Compare May 28, 2025 19:19
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 96.49%. Comparing base (b619c48) to head (5da9ede).

Files with missing lines Patch % Lines
src/button/internal.tsx 40.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3540      +/-   ##
==========================================
- Coverage   96.55%   96.49%   -0.07%     
==========================================
  Files         804      804              
  Lines       23438    23463      +25     
  Branches     8174     7774     -400     
==========================================
+ Hits        22630    22640      +10     
- Misses        754      816      +62     
+ Partials       54        7      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaemonCahill DaemonCahill force-pushed the scottob-button-style-api branch from cfda0f5 to 1269058 Compare May 30, 2025 15:13
just-boris
just-boris previously approved these changes May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants