Improve documentation #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Feb 11, 2024
yadaiio
force-pushed
the
Improve_documentation
branch
from
8cab698 to
ee7f5c0
Compare
|
Thanks for noticing this @clue. Should be fixed now. 👍 |
clue
reviewed
Feb 13, 2024
yadaiio
force-pushed
the
Improve_documentation
branch
from
ee7f5c0 to
011c69f
Compare
clue
reviewed
Feb 26, 2024
yadaiio
force-pushed
the
Improve_documentation
branch
from
011c69f to
f094b73
Compare
clue
reviewed
Feb 26, 2024
README.md
Outdated
| @@ -120,12 +130,12 @@ try { | |||
| } | |||
| ``` | |||
|
|
|||
| Similarly, you can also process multiple lookups concurrently and await an array of results: | |||
| Similarly, you can also process multiple resolves concurrently and await an array of results: | |||
There was a problem hiding this comment.
Not sure about this, I prefer the previous version, WDYT?
There was a problem hiding this comment.
I thought since I changed the lookup in the code, I thought it would add up to change the describing text above, but it is also okay to use this here. I changed it now @clue
clue
reviewed
Feb 26, 2024
yadaiio
force-pushed
the
Improve_documentation
branch
from
f094b73 to
0970cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #19.
References: clue/reactphp-tar#20, clue/reactphp-redis#117 and clue/reactphp-sqlite#43.